Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable GCC VTA for SWIG-generated file to reduce build time #1253

Merged
merged 1 commit into from
Jun 19, 2023
Merged

disable GCC VTA for SWIG-generated file to reduce build time #1253

merged 1 commit into from
Jun 19, 2023

Conversation

k-v1
Copy link
Contributor

@k-v1 k-v1 commented Jun 18, 2023

Fix sonic-net/sonic-buildimage#13775

-fvar-tracking-assignments
Annotate assignments to user variables early in the compilation and attempt to carry the annotations over throughout the compilation all the way to the end, in an attempt to improve debug information while optimizing.
By default, this flag is enabled.

There is no reason to use this flag for auto-generated code.

@k-v1
Copy link
Contributor Author

k-v1 commented Jun 19, 2023

Test:

SONIC_CONFIG_MAKE_JOBS=20
Build only libsairedis.

now:

make target/debs/bullseye/libsairedis_1.0.0_amd64.deb-clean
make target/debs/bullseye/libsairedis_1.0.0_amd64.deb
grep Elapsed target/debs/bullseye/libsairedis_1.0.0_amd64.deb.log
[23:48:43] Elapsed time: 0h 12m 28s

with patch:

make target/debs/bullseye/libsairedis_1.0.0_amd64.deb-clean
make target/debs/bullseye/libsairedis_1.0.0_amd64.deb
grep Elapsed target/debs/bullseye/libsairedis_1.0.0_amd64.deb.log
Elapsed time: 0h 1m 52s

@kcudnik
Could you please review this PR?

@kcudnik kcudnik merged commit 321ce74 into sonic-net:master Jun 19, 2023
@k-v1 k-v1 deleted the disable_vta_for_swig branch June 19, 2023 09:57
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Jun 20, 2023
@dprital
[submodule] Advance sonic-sairedis pointer
a9f9720 
Update sonic-sairedis submodule pointer to include the following:
* 321ce74 Disable GCC VTA for SWIG-generated file ([sonic-net#1253](sonic-net/sonic-sairedis#1253))

Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcudnik kcudnik kcudnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[build] libsairedis takes 1.5h to build (used to be 3-4 min in the past)
2 participants
@k-v1 @kcudnik